Skip to content

Fixes resource_strip_prefix on Windows #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixes resource_strip_prefix on Windows #745

wants to merge 1 commit into from

Conversation

@majcherm-da
Copy link
Contributor

@majcherm-da majcherm-da commented May 9, 2019

This introduces a build/test case which fails on Windows (with resource_strip_prefix used leaving / as first char) with:

PS C:\Users\...\rules_scala> bazel build //test/resource_strip_prefix/...
INFO: Analysed target //test/resource_strip_prefix:test-lib (1 packages loaded, 3 targets configured).
INFO: Found 1 target...
ERROR: C:/users/.../rules_scala/test/resource_strip_prefix/BUILD:3:1: scala //test/resource_strip_prefix:test-lib failed (Exit 1)
java.nio.file.AccessDeniedException: test\resource_strip_prefix\src\test\resources\resource.txt -> \resource.txt
        at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:83)
        at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
        at sun.nio.fs.WindowsFileCopy.copy(WindowsFileCopy.java:205)
        at sun.nio.fs.WindowsFileSystemProvider.copy(WindowsFileSystemProvider.java:278)
        at java.nio.file.Files.copy(Files.java:1274)
        at io.bazel.rulesscala.scalac.ScalacProcessor.copyResources(ScalacProcessor.java:309)
        at io.bazel.rulesscala.scalac.ScalacProcessor.processRequest(ScalacProcessor.java:73)
        at io.bazel.rulesscala.worker.GenericWorker.run(GenericWorker.java:114)
        at io.bazel.rulesscala.scalac.ScalaCInvoker.main(ScalaCInvoker.java:41)
Target //test/resource_strip_prefix:test-lib failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 4.016s, Critical Path: 2.98s
INFO: 0 processes.
FAILED: Build did NOT complete successfully

and fixes it in ScalacProcessor.java

@majcherm-da majcherm-da requested a review from johnynek as a code owner May 9, 2019 10:25
@majcherm-da majcherm-da mentioned this pull request May 9, 2019
Merged
5 tasks
@johnynek
Copy link
Contributor

johnynek commented May 9, 2019

The windows test failed with an error that the worker sent an unparseable result. I restarted it, but it is a bit concerning. I don't recall seeing that in osx/linux.

This would happen if there is a println somewhere since the workers operate with stdin/stdout.

@johnynek
Copy link
Contributor

johnynek commented May 13, 2019

windows build failed again. Can you take a look and diagnose?

@johnynek johnynek mentioned this pull request May 13, 2019
Closed
@johnynek
Copy link
Contributor

johnynek commented Jul 30, 2019

do you want to merge master and try again?

@ittaiz
Copy link
Contributor

ittaiz commented Aug 17, 2019

@majcherm-da do you think you'll have capacity for this?

@ittaiz
Copy link
Contributor

ittaiz commented May 2, 2020

@majcherm-da is this still relevant?
@d-haxton @simuons maybe one of you can say after the changes you did in that area?

@liucijus
Copy link
Collaborator

liucijus commented Jan 31, 2024

closing as stale, feel free to reopen

@liucijus liucijus closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnynek johnynek Awaiting requested review from johnynek

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@majcherm-da @johnynek @ittaiz @liucijus @googlebot